Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Add browser entrypoint #49

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jul 13, 2022

Adds a separate entry point for browser environments that omits Node.js exclusive streams. The entry point is added as the browser field in the package.json.

Fixes #48

@FrederikBolding FrederikBolding changed the title Add browser entrypoint BREAKING: Add browser entrypoint Jul 13, 2022
@FrederikBolding FrederikBolding merged commit 52fbc06 into main Jul 13, 2022
@FrederikBolding FrederikBolding deleted the fb/browser-exports branch July 13, 2022 11:53
Gudahtt added a commit to MetaMask/phishing-warning that referenced this pull request Aug 2, 2022
This reverts commit e9eddaf. This
change was made to resolve a breakage introduced in
`@metamask.post-message-stream`. This breakage was fixed in v6 of that
library, so we don't need to use a direct import anymore.

For further details, see: MetaMask/post-message-stream#49
Gudahtt added a commit to MetaMask/phishing-warning that referenced this pull request Aug 3, 2022
This reverts commit e9eddaf. This
change was made to resolve a breakage introduced in
`@metamask.post-message-stream`. This breakage was fixed in v6 of that
library, so we don't need to use a direct import anymore.

For further details, see: MetaMask/post-message-stream#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate exports for Node.js and browser environments
2 participants